Merge pull request #276 from invopop/release-uuid-fix

UUID: fix unmarshal - release 0.74.1

Author: samlown

CHANGELOG.md

@@ -4,6 +4,14 @@ All notable changes to GOBL will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). See also the [GOBL versions](https://docs.gobl.org/overview/versions) documentation site for more details.
 
+## [v0.74.1] - 2024-05-23
+
+UUID Unmarshal fix.
+
+### Fixed
+
+- UUID: parsing empty strings from JSON no longer causes error.
+
 ## [v0.74.0] - 2024-05-23
 
 Refining UUID library and moving to using version 7 as the default in GOBL.

uuid/uuid.go

@@ -242,13 +242,14 @@ func Normalize(u *UUID) {
 	}
 }
 
-// UnmarshalText will ensure the UUID is always a valid UUID when unmarshalling.
+// UnmarshalText will ensure the UUID is always a valid UUID when unmarshalling
+// and just return an empty value if incorrect.
 func (u *UUID) UnmarshalText(txt []byte) error {
-	id, err := uuid.Parse(string(txt))
+	id, err := Parse(string(txt))
 	if err != nil {
 		return err
 	}
-	*u = UUID(id.String())
+	*u = id
 	return nil
 }
 

uuid/uuid_test.go

@@ -132,7 +132,7 @@ func TestUUIDUnmarshalJSON(t *testing.T) {
 			name: "empty string",
 			data: `{"id":""}`,
 			want: m{},
-			err:  "invalid UUID length: 0",
+			err:  "",
 		},
 		{
 			name: "null",

version.go

@@ -8,7 +8,7 @@ import (
 type Version string
 
 // VERSION is the current version of the GOBL library.
-const VERSION Version = "v0.74.0"
+const VERSION Version = "v0.74.1"
 
 // Semver parses and returns semver
 func (v Version) Semver() *semver.Version {