Merge pull request #282 from invopop/mx-empty-line-taxes

MX: allow line taxes to be empty

Author: samlown

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to GOBL will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). See also the [GOBL versions](https://docs.gobl.org/overview/versions) documentation site for more details.
 
+## [v0.75.1] - 2024-05-07
+
+### Change
+
+- MX: allow line taxes to be empty.
+
 ## [v0.75.0] - 2024-05-06
 
 ### Added

regimes/mx/invoice.go

@@ -125,10 +125,6 @@ func (v *invoiceValidator) validLine(value interface{}) error {
 	return validation.ValidateStruct(line,
 		validation.Field(&line.Quantity, num.Positive),
 		validation.Field(&line.Total, num.Positive),
-		validation.Field(&line.Taxes,
-			validation.Required,
-			validation.Skip, // Prevents each tax's `ValidateWithContext` function from being called again.
-		),
 	)
 }
 

regimes/mx/invoice_test.go

@@ -130,11 +130,6 @@ func TestLineValidation(t *testing.T) {
 
 	inv.Lines[0].Item.Price = num.MakeAmount(-1, 0)
 	assertValidationError(t, inv, "lines: (0: (total: must be greater than 0.).)")
-
-	inv = validInvoice()
-
-	inv.Lines[0].Taxes = nil
-	assertValidationError(t, inv, "lines: (0: (taxes: cannot be blank.).)")
 }
 
 func TestPaymentInstructionsValidation(t *testing.T) {
@@ -228,6 +223,7 @@ func TestInvoiceDiscountValidation(t *testing.T) {
 }
 
 func assertValidationError(t *testing.T, inv *bill.Invoice, expected string) {
+	t.Helper()
 	require.NoError(t, inv.Calculate())
 	err := inv.Validate()
 	require.Error(t, err)

version.go

@@ -8,7 +8,7 @@ import (
 type Version string
 
 // VERSION is the current version of the GOBL library.
-const VERSION Version = "v0.75.0"
+const VERSION Version = "v0.75.1"
 
 // Semver parses and returns semver
 func (v Version) Semver() *semver.Version {