Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update for the SDK #107

Closed
NotJDoe opened this issue Jan 8, 2025 · 3 comments
Closed

Dependency update for the SDK #107

NotJDoe opened this issue Jan 8, 2025 · 3 comments

Comments

@NotJDoe
Copy link

NotJDoe commented Jan 8, 2025

Hi,

I installed this SDK and via compose and it installed v1.1.0. I then updated it via compose and the following happened:

composer update
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 1 removal

  • Removing symfony/clock (v7.2.0)
  • Upgrading aws/aws-sdk-php (3.336.9 => 3.336.10)
  • Upgrading invoiceninja/sdk-php (v1.1.0 => v1.2.0)
  • Downgrading nesbot/carbon (3.8.4 => 2.72.6)
  • Downgrading symfony/translation (v7.2.2 => v6.4.13)
    Writing lock file
    Installing dependencies from lock file (including require-dev)
    Package operations: 0 installs, 4 updates, 1 removal
  • Downloading symfony/translation (v6.4.13)
  • Downloading nesbot/carbon (2.72.6)
  • Downloading aws/aws-sdk-php (3.336.10)
  • Downloading invoiceninja/sdk-php (v1.2.0)
  • Removing symfony/clock (v7.2.0)
  • Downgrading symfony/translation (v7.2.2 => v6.4.13): Extracting archive
  • Downgrading nesbot/carbon (3.8.4 => 2.72.6): Extracting archive
  • Upgrading aws/aws-sdk-php (3.336.9 => 3.336.10): Extracting archive
  • Upgrading invoiceninja/sdk-php (v1.1.0 => v1.2.0): Extracting archive

The update to v1.2.0 forced the removal of symfony/clock and downgraded symfony/translation (v7.2.2 => v6.4.13) and nesbot/carbon (3.8.4 => 2.72.6).

Can the dependencies for the SDK be updated to accommodate the later versions and prevent code regression?

@NotJDoe NotJDoe changed the title Dependancy update for the SDK Dependency update for the SDK Jan 8, 2025
@turbo124
Copy link
Member

turbo124 commented Jan 9, 2025

Where are you running composer u from? the package or your primary application?

@NotJDoe
Copy link
Author

NotJDoe commented Jan 9, 2025

from the root of my application, same folder as artisan, I did a composer require invoiceninja/sdk-php from my application root which installed 1.1.0, then did composer u and the above happened

@turbo124
Copy link
Member

turbo124 commented Jan 9, 2025

#108

@turbo124 turbo124 closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants