-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove_accents option does not work properly anymore #444
Comments
Have encountered same issues with Lithuanian and Latvian letters too |
We need to fix this! Currently im travelling. So not much time to attend to this. |
Why not just revert to the former solution |
Because of the mentioned license issue. There are some good alternatives. Like built-ins or alternative libraries ( adding extra dependencies is not preferred). |
What about using the normal form KD ? |
Yes, that seems to fix it..
|
It is probably an good idea to add a test for the remove accents function. |
Since the removal of the unidecode library and its replacement with the unicodedata module in commit 4d517d1, the remove_accents option does not work properly anymore.
Eg: in French, 'référence' is replaced with 'rfrence'.
It seems that the normal form KC is here responsible as the normal form KD works fine with this example ('référence' is properly replaced with 'reference').
The text was updated successfully, but these errors were encountered: