Refactor resolver

[notaphplover]

As commented at #1132 (comment), Resolver can be refactored.

• A resolveBinding function could be extracted.
• result is guaranteed to be undefined | T | Promise if !(targetIsAnArray && targetParentIsNotAnArray)
• resolveInstance should be passed as generic paramenter:

...
        } else if (binding.type === BindingTypeEnum.Instance && binding.implementationType !== null) {
            result = resolveInstance<T>(
                binding,
                binding.implementationType,
                childRequests,
                _resolveRequest<T>(requestScope)
            );
        } else {
...

[notaphplover]

@tonyhallett This is the issue, do you agree to all those statements? If that's the case just answer this message and I'll submit a PR

[tonyhallett]

Yes !

The T in `Binding' is TActivated, the resolved value of T.
add image here
The T in the "get" methods applies equally to resolve - if you type correctly you get it back from the binding ( or cache )

[tonyhallett]

We also need to change the nonsense T's to any

InversifyJS/src/bindings/binding.ts

Line 34 in 094bcd6

public factory: interfaces.FactoryCreator<T> | null;

to match the interface.

[tonyhallett]

Perhaps we should change Binding<T> to Binding<TActivated> to be clear.

[tonyhallett]

@notaphplover Taking this one

[notaphplover]

@notaphplover Taking this one

I already made the PR sorry. There is a test which fails on node14 es6 build, I'll be missing for some hours so if you want could you see what's happening?

[tonyhallett]

I will have a look

[notaphplover]

Closing as #1323 is merged