WebStyle: HttpOnly cookie attribute #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tiborsimko have you checked if BibEdit (ajax-based) still works? |
|
@kaplun Yes, I did. (Just one field value change, no auto-completion etc.) |
|
👍 good for me |
* SECURITY Adds back the `HttpOnly` cookie attribute in order to better protect against potential XSS vulnerabilities. (closes inveniosoftware#3064) Signed-off-by: Tibor Simko <[email protected]> Reviewed-by: Samuele Kaplun <[email protected]>
tiborsimko
force-pushed
the
set-cookie-http-only
branch
from
1203c5c
to
e83f600
Compare
|
Thanks, amended commit log message, and merged as e83f600. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpOnlycookie attribute in order to betterprotect against potential XSS vulnerabilities. (closes WebSession: HttpOnly cookie attribute #3064)
Signed-off-by: Tibor Simko [email protected]