Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSearch: do not show title/description/keyword of deleted records #1682

Open
jeromecaffaro opened this issue Apr 30, 2014 · 1 comment
Open

WebSearch: do not show title/description/keyword of deleted records #1682

jeromecaffaro opened this issue Apr 30, 2014 · 1 comment
Assignees
@tiborsimko
Labels
Branch: legacy Component: WebSearch Type: bug
Milestone
v1.3.0

Comments

@jeromecaffaro
Copy link
Member

Originally on 2014-01-16

Once a record is deleted using BibEdit, its metadata remains accessible and is only flagged as deleted (adding 980__a:DELETED, without removing other fields). Functions such as search_engine_utils.get_fieldvalues(..) will consequently still return some metadata for these deleted records.

websearch_templates.tmpl_record_page_header_content(..) (or its caller) should therefore be updated to not return any value when considering a deleted record.
(Note that failing to do so might reveal the title/keywords/description of records that used to be restricted, since the restriction is removed when losing collection membership)

Alternatively BibEdit could be updated to wipe the record metadata when deleting it.
@tiborsimko tiborsimko added this to the v1.x milestone Sep 19, 2014
@tiborsimko tiborsimko modified the milestones: v1.2.0, v1.x Oct 3, 2014
kaplun added a commit to kaplun/invenio that referenced this issue Oct 3, 2014
@kaplun
WebSearch: no headers for deleted records
3fd0b6c 
* Avoids populating title/description/keyword HTML headers for
  deleted records.
  (closes inveniosoftware#1682)

Signed-off-by: Samuele Kaplun <[email protected]>
@kaplun kaplun mentioned this issue Oct 3, 2014
Closed
kaplun added a commit to kaplun/invenio that referenced this issue Oct 3, 2014
@kaplun
WebSearch: no headers for deleted records
6fea1fc 
* Avoids populating title/description/keyword HTML headers for
  deleted records.
  (closes inveniosoftware#1682)

Signed-off-by: Samuele Kaplun <[email protected]>
@tiborsimko tiborsimko removed the p_major label Aug 1, 2016
@kaplun kaplun assigned tiborsimko and unassigned kaplun Jan 5, 2017
@kaplun
Copy link
Member

kaplun commented Jan 5, 2017

@tiborsimko I think this code was in good state and ready for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiborsimko tiborsimko

Labels
Branch: legacy Component: WebSearch Type: bug
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

WebSearch: no headers for deleted records kaplun/invenio
4 participants
@kaplun @jirikuncar @tiborsimko @jeromecaffaro