WIP spires: support for particles #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a list of particles. * Identifies particles as "particle" instead of "value". (closes #38) Signed-off-by: Panos Paparrigopoulos <[email protected]>
| @@ -0,0 +1,783 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Isn't spires contrib config enough?
|
@Panos512 all changes should touch only |
jirikuncar
changed the title
|
@jirikuncar Thanks for the suggestions! I will get back to it as soon as possible. |
|
ping @Panos512 what was the status of this PR? |
|
@jmartinm I can pick it up again if we still need it. |
Closed
|
@kaplun you mentioned Panos left already and this PR has been sleeping for a year or so, do you think you'll have time to take look at it should we close it for now? |
|
No, I'm going to take care of it (but not now, because I've got a lot on my plate currently...). |
|
Closing PR as it's been stale for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes search: support for particles #38)
Signed-off-by: Panos Paparrigopoulos [email protected]