-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make invenio_users_resources
dependency optional
#486
Comments
Hello, working on diffrent invenio instance not depended on invenio-{records, users}-resources I haven't hit this problem. However, in order for the bootstrap theme to be correctly build I have to define explicitly |
Hi, thanks for your reply. Yes, I define |
Hey @PascalRepond ! I think that was an overlook from our side and we are working on a fix. Thanks a lot for reporting it. |
Hey, we just released a new version with the fix https://pypi.org/project/invenio-accounts/5.1.1/ (kudos to @utnapischtim ) |
Package version (if known): 5.1.0
Describe the bug
A dependency to
invenio_users_resources
was added, which installs some dependencies that might not be needed in other projects and might create errors.Specifically,
invenio webpack buildall
returns an error if a project uses bootstrap3 becauseinvenio-administration
is now a subdependency and is only compatible with semantic-ui.Expected behavior
The package
invenio_users_resources
dependency should be optional instead of required.The text was updated successfully, but these errors were encountered: