Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make invenio_users_resources dependency optional #486

Open
PascalRepond opened this issue Aug 6, 2024 · 4 comments
Open

Make invenio_users_resources dependency optional #486

PascalRepond opened this issue Aug 6, 2024 · 4 comments
Labels

Comments

@PascalRepond
Copy link

Package version (if known): 5.1.0

Describe the bug

A dependency to invenio_users_resources was added, which installs some dependencies that might not be needed in other projects and might create errors.

Specifically, invenio webpack buildall returns an error if a project uses bootstrap3 because invenio-administration is now a subdependency and is only compatible with semantic-ui.

Expected behavior

The package invenio_users_resources dependency should be optional instead of required.

@zzacharo
Copy link
Member

zzacharo commented Aug 6, 2024

Hello, working on diffrent invenio instance not depended on invenio-{records, users}-resources I haven't hit this problem. However, in order for the bootstrap theme to be correctly build I have to define explicitly APP_THEME = ["bootstrap3"]. Have you tried this?

@PascalRepond
Copy link
Author

Hello, working on diffrent invenio instance not depended on invenio-{records, users}-resources I haven't hit this problem. However, in order for the bootstrap theme to be correctly build I have to define explicitly APP_THEME = ["bootstrap3"]. Have you tried this?

Hi, thanks for your reply. Yes, I define APP_THEME = ["bootstrap3"] but since v5.1.0 (see https://github.com/inveniosoftware/invenio-accounts/blame/710781e95ebb754e1eb579decc298eb44e9d7ac6/setup.cfg#L40), invenio-accounts depends on invenio-user-resources which itself depends on a bunch of other packages that do not define APP_THEME = ["bootstrap3"] and crash the webpack build.

@zzacharo
Copy link
Member

zzacharo commented Aug 8, 2024

Hey @PascalRepond ! I think that was an overlook from our side and we are working on a fix. Thanks a lot for reporting it.

@zzacharo
Copy link
Member

zzacharo commented Aug 8, 2024

Hey, we just released a new version with the fix https://pypi.org/project/invenio-accounts/5.1.1/ (kudos to @utnapischtim )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants