Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send confirm email cannot be used properly #367

Open
nkenobi opened this issue May 2, 2021 · 1 comment
Open

Send confirm email cannot be used properly #367

nkenobi opened this issue May 2, 2021 · 1 comment
Labels

Comments

@nkenobi
Copy link

nkenobi commented May 2, 2021

Package version (if known): latest

Describe the bug

The "send-confirmation-email" API requires login, which prevents the most frequent use case which is to send confirm email again

Steps to Reproduce

  1. Register with confirmation and either the email is expired (quite likely with the default 30mins) or lost
  2. So user is unable to log in yet
  3. Hence downstream app provides Resend confirmation button,
  4. But cannot call API for said purpose since SendConfirmationEmailView is decorated with login_required

Expected behavior

Ideally, login_required decorator should be removed since the typical use case here is for resending email

Screenshots (if applicable)

I've attempted to override this decorator with a subclass to set decorators = (), but it doesn't seem to work.
Of course, a separate blueprint/url could be created to workaround issue, but would be far from optimal

@nkenobi nkenobi added the bug label May 2, 2021
@lnielsen
Copy link
Member

So I'm might be wrong here, but I think it's correct that the view requires login. The view is for when a confirmation is NOT required to login. In which are the user can log in (if they remember their password) and ask to resend the confirmation email.

Instead a user should reset their password (which will also send an email) if the link expired. However, here might be a bug that it seems like the ForgotPasswordView requires an authenticated user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants