Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: integrate changes from invenio-saml #296

Open
3 tasks
Tracked by #12
slint opened this issue Jan 22, 2020 · 0 comments
Open
3 tasks
Tracked by #12

global: integrate changes from invenio-saml #296

slint opened this issue Jan 22, 2020 · 0 comments

Comments

@slint
Copy link
Member

slint commented Jan 22, 2020

From https://github.com/inveniosoftware/invenio-saml/tree/master/invenio_saml/invenio_accounts the different files/functions have to be moved in the equivalent files in this module:

  • models.py: defines UserIdentity, and makes sure that it doesn't clash with invenio_oauthclient.models.UserIdentity
    • This requires performing the same compatibility "trick" to import UserIdentity correctly
  • utils.py + errors.py: move all external identifiers helpers functions, and make a list of places that can re-use these functions, invenio_oauthclient/contrib/*.py, invenio_oauthclient/handlers.py`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant