Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential race condition when getting PR labels for releasing #2482

Open
d9su opened this issue Dec 4, 2024 · 0 comments
Open

Potential race condition when getting PR labels for releasing #2482

d9su opened this issue Dec 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@d9su
Copy link

d9su commented Dec 4, 2024

Describe the bug

The label function by default gets the labels from the most recently merged PR on any branch, not the most recently merged PR on the target branch. This can cause a potential race condition messing up releases.

For example:

  1. PR A is merged into master, awaiting a release to be generated.
  2. PR B is merged into next immediately after, with a skip-release label.
  3. When auto is run for PR A, it picks up the skip-release label from PR B, thus not end up creating a release.

This issue will happen for any project with multiple release tracks.

To Reproduce

Repeat the above steps, and observe that the release labels for PR B will be used for the release of PR A.

Expected behavior

When auto is run on a specific branch to create releases, it should only pick up PRs merged from that branch, and not any other branches.

@d9su d9su added the bug Something isn't working label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant