Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services can add test results in sessions without access to the test type. #247

Open
doumdi opened this issue Apr 2, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@doumdi
Copy link
Member

doumdi commented Apr 2, 2024

Describe the bug
Services can add test results in sessions without access to the test type.

To Reproduce
POST test results to the /api/service/tests endpoint.

  • There is no verification if the session's project has access to the test type.
  • A session may not be attached to any project directly, making it hard to verify.
  • A test can be created by either (user, device, participant, service), which makes it hard to verify.

Expected behavior
status_code 403 should be returned instead of 200, OK.

@doumdi doumdi added the bug Something isn't working label Apr 2, 2024
@doumdi doumdi changed the title Services can add test results in sessions without access to the test. Services can add test results in sessions without access to the test type. Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants