-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ci/pr/required-check from bors.toml #4923
Conversation
This could be an alternative to #4920 but bors is not very useful if it checks only cabal files. |
We had a discussion in the node team and resolved not have Cicero or Hydra builds as required checks because they fail too often and are preventing us from merging PRs. The hope is we can have another out-of-band process for ensuring the Cicero or Hydra builds continue to work. |
@newhoggy what about requiring a minimal cicero job that would only do the nix build of cardano-node for linux? |
You can put a cicero job in CI if you like but we are not using it with bors. It's been pretty bad for the past few months merging things into cardano-node with cicero. We are going to use github actions and we can notify devops when other jobs fail but that should not encumber my team. |
e2a4cba
to
e20ed1c
Compare
e20ed1c
to
dcf5a52
Compare
bors r+ |
Build succeeded: |
No description provided.