Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ci/pr/required-check from bors.toml #4923

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

newhoggy
Copy link
Contributor

No description provided.

@newhoggy newhoggy marked this pull request as ready for review February 28, 2023 23:37
@newhoggy newhoggy requested review from Jimbo4350 and a team as code owners February 28, 2023 23:37
@dermetfan
Copy link
Contributor

This could be an alternative to #4920 but bors is not very useful if it checks only cabal files.

@newhoggy
Copy link
Contributor Author

newhoggy commented Mar 1, 2023

We had a discussion in the node team and resolved not have Cicero or Hydra builds as required checks because they fail too often and are preventing us from merging PRs. The hope is we can have another out-of-band process for ensuring the Cicero or Hydra builds continue to work.

@jbgi
Copy link
Contributor

jbgi commented Mar 1, 2023

@newhoggy what about requiring a minimal cicero job that would only do the nix build of cardano-node for linux?
I think that should avoid most of the failures of cicero build while still ensuring a minimal nix support for cardano-node master.

@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Mar 1, 2023

@newhoggy what about requiring a minimal cicero job that would only do the nix build of cardano-node for linux? I think that should avoid most of the failures of cicero build while still ensuring a minimal nix support for cardano-node master.

You can put a cicero job in CI if you like but we are not using it with bors. It's been pretty bad for the past few months merging things into cardano-node with cicero. We are going to use github actions and we can notify devops when other jobs fail but that should not encumber my team.

@Jimbo4350 Jimbo4350 force-pushed the newhoggy/remove-ci/pr/required-check branch 12 times, most recently from e2a4cba to e20ed1c Compare March 1, 2023 17:15
@Jimbo4350 Jimbo4350 force-pushed the newhoggy/remove-ci/pr/required-check branch from e20ed1c to dcf5a52 Compare March 1, 2023 17:27
@Jimbo4350
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 1, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 78d1ed5 into master Mar 1, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/remove-ci/pr/required-check branch March 1, 2023 19:17
@jbgi jbgi mentioned this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants