Fix Data.Aeson.Types import #4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
requested review from
dcoutts,
Jimbo4350,
newhoggy,
JaredCorduan and
CarlosLopezDeLara
as code owners
Importing it as `Data.Aeson.Types.Internal` was confusing. The Haskell convention is that module with `Internal` in the name contain unsafe functions or unstable APIs.
erikd
force-pushed
the
erikd/aeson-fix
branch
from
120a3b2
to
f9d5445
Compare
newhoggy
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.