New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ghc-9.2 and partial support for CHaP #4701

Merged

iohk-bors merged 19 commits into master from erikd/ghc-9.2

Feb 6, 2023

Contributor

erikd commented Dec 9, 2022

No description provided.

erikd requested review from Jimbo4350, newhoggy, a team, coot, deepfire, jutaro, mgmeier, fmaste, cleverca22, dcoutts, JaredCorduan, LudvikGalois and CarlosLopezDeLara as code owners

December 9, 2022 09:08

erikd force-pushed the erikd/ghc-9.2 branch 3 times, most recently from f8fe954 to c208ab2 Compare

December 14, 2022 04:23

newhoggy reviewed

View reviewed changes

cardano-testnet/src/Testnet/Byron.hs Outdated Show resolved Hide resolved

newhoggy reviewed

View reviewed changes

cardano-testnet/src/Testnet/Cardano.hs Outdated Show resolved Hide resolved

newhoggy reviewed

View reviewed changes

cardano-testnet/src/Testnet/Shelley.hs Outdated Show resolved Hide resolved

newhoggy reviewed

View reviewed changes

cardano-testnet/test/Test/Cli/Babbage/LeadershipSchedule.hs Outdated Show resolved Hide resolved

newhoggy reviewed

View reviewed changes

cardano-testnet/test/Test/Cli/Babbage/LeadershipSchedule.hs Outdated Show resolved Hide resolved

newhoggy reviewed

View reviewed changes

cardano-testnet/test/Test/Cli/KesPeriodInfo.hs Outdated Show resolved Hide resolved

newhoggy reviewed

View reviewed changes

cardano-testnet/test/Test/Cli/KesPeriodInfo.hs Outdated Show resolved Hide resolved

newhoggy reviewed

View reviewed changes

cardano-testnet/test/Test/Cli/KesPeriodInfo.hs Outdated Show resolved Hide resolved

erikd force-pushed the erikd/ghc-9.2 branch 2 times, most recently from 7d6c325 to 7986df9 Compare

December 15, 2022 06:20

Contributor

angerman commented Dec 15, 2022

I think we need to

allow-newer: katip:Win32

🤦

erikd force-pushed the erikd/ghc-9.2 branch 3 times, most recently from 20d323a to bb31fbb Compare

December 16, 2022 04:50

Soupstraw and others added 4 commits

February 6, 2023 11:19


          Added lower bounds to dependencies based on cabal.project constraints

4d132ef


          update ouroboros-network and iohk-nix

1b8d4d5


          Updated ledger and ouroboros-network dependencies

8c3465b

Co-authored-by: Erik de Castro Lopo <[email protected]>
Co-authored-by: Moritz Angermann <[email protected]>
Co-authored-by: Marcin Szamotulski <[email protected]>
Co-authored-by: Michael Karg <[email protected]>
Co-authored-by: Jordan Millar <[email protected]>


          cardano-api: Fix Eq instances

64031f5

The GHC handling of pattern matches has changed for `ghc-9.2` resulting
in incomplete pattern match errors with the old code.

erikd force-pushed the erikd/ghc-9.2 branch from c750187 to c34991f Compare

February 6, 2023 00:20

Contributor

angerman commented Feb 6, 2023

Bors try

iohk-bors bot added a commit that referenced this pull request


          Try #4701:

496ef3a

Contributor

iohk-bors bot commented Feb 6, 2023

try

Build succeeded:

ci/pr/required

angerman approved these changes

View reviewed changes

Contributor

angerman left a comment

LGTM, let's do this!

erikd and others added 10 commits

February 6, 2023 01:47


          Add support for ghc-9.2 and CHaP

11f654f


          CI: Add ghc-9.2.4 to the build matrix

e8ed61a


          Add ghc-9.2.5 variant to nix ci.

76d1c7c


          Fix plutus related benchmarking code

1df24e2

Co-authored-by: Erik de Castro Lopo <[email protected]>


          cardano-node: restructuring tracers

baf1d4b


          Updated ledger and ouroboros-network dependencies

0e8d611


          Updated cardano-node for 1.35.5 releasefixed

b5640c2

* fixed formatting


          Updated ledger and ouroboros-network dependencies

5ff7d96

Co-authored-by: Erik de Castro Lopo <[email protected]>
Co-authored-by: Moritz Angermann <[email protected]>
Co-authored-by: Marcin Szamotulski <[email protected]>
Co-authored-by: Michael Karg <[email protected]>
Co-authored-by: Jordan Millar <[email protected]>


          Add support for ghc-9.2 and CHaP

b2f4ed2

Co-authored-by: Moritz Angermann <[email protected]>


          Nix and CI related fixes

7b90482

angerman force-pushed the erikd/ghc-9.2 branch from c34991f to 7b90482 Compare

February 6, 2023 01:49

Contributor

angerman commented Feb 6, 2023

bors try

iohk-bors bot added a commit that referenced this pull request


          Try #4701:

43a79b6

Contributor Author

erikd commented Feb 6, 2023

bors merge

Contributor

iohk-bors bot commented Feb 6, 2023

try

Timed out.

Contributor

iohk-bors bot commented Feb 6, 2023

Build succeeded:

ci/pr/required

iohk-bors bot merged commit 0c5d82b into master

Contributor

angerman commented Feb 6, 2023

bors merge

Contributor

iohk-bors bot commented Feb 6, 2023

Already running a review

iohk-bors bot deleted the erikd/ghc-9.2 branch

February 6, 2023 04:06

newhoggy mentioned this pull request

[FR] - Upgrade to GHC 9.2.4? #4256

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

newhoggy newhoggy left review comments

angerman angerman approved these changes

Jimbo4350 Awaiting requested review from Jimbo4350

coot Awaiting requested review from coot

deepfire Awaiting requested review from deepfire

jutaro Awaiting requested review from jutaro

mgmeier Awaiting requested review from mgmeier

fmaste Awaiting requested review from fmaste

cleverca22 Awaiting requested review from cleverca22

dcoutts Awaiting requested review from dcoutts

JaredCorduan Awaiting requested review from JaredCorduan

LudvikGalois Awaiting requested review from LudvikGalois

CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Labels

None yet