Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a native tokens tutorial and exercises to a newly created MA folder #4562

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

olgahryniuk
Copy link
Contributor

@Jimbo4350 As per our discussion yesterday, I've created a new 'native tokens' folder where I moved 'multi-assets', added a tutorial, exercises, and exchange management scenarios. Please review & thank you!
The existing multi-assets file is different from exchange-scenarios so there was no need in merging them together.

@olgahryniuk olgahryniuk requested a review from a team as a code owner October 26, 2022 09:10
@Jimbo4350
Copy link
Contributor

@olgahryniuk you need to create a branch off of master. Currently you are committing directly to master.

@olgahryniuk
Copy link
Contributor Author

Jordan, this is a separate branch. I forked the node repo and renamed it to native tokens: https://github.com/input-output-hk/cardano-node-native-tokens-folder-TW.

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good work. A few more comments to discuss.

README.rst Outdated Show resolved Hide resolved
doc/reference/native-tokens/02-getting-started.md Outdated Show resolved Hide resolved
doc/reference/native-tokens/02-getting-started.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Three minor changes.

README.rst Outdated Show resolved Hide resolved
doc/reference/native-tokens/01-multi-assets.md Outdated Show resolved Hide resolved
Update multi-assets.md

Rename doc/reference/multi-assets.md to doc/reference/native-tokens/multi-assets.md

Rename multi-assets.md to 01-multi-assets.md

Rename getting-started.md to 02-getting-started.md

Create 03-exercises.md

Update 01-multi-assets.md

Create 04-exchange-scenarios.md

delete general intro to include in readme

add native tokens intro to readme file

delete duplicated script samples

Update README.rst

Delete extra details & point to readmes

Shorten the native tokens overview

add links to native tokens tutorials

Adding a link to getting started tutorial

fix native tokens links
@Jimbo4350 Jimbo4350 merged commit 55ec227 into IntersectMBO:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants