Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment files in Github Actions #4550

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Oct 23, 2022

@newhoggy newhoggy marked this pull request as ready for review October 23, 2022 11:11
@newhoggy newhoggy requested review from Jimbo4350 and a team as code owners October 23, 2022 11:11
@newhoggy
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 27, 2022
4550: Use environment files in Github Actions r=newhoggy a=newhoggy

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Co-authored-by: John Ky <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 28, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from Jimbo4350 and/or input-output-hk/devops.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@newhoggy
Copy link
Contributor Author

bors r+

Copy link
Contributor

@MarcFontaine MarcFontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the example in GitHub Actions: Deprecating save-state and set-output commands.

@MarcFontaine
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 28, 2022

Already running a review

@newhoggy
Copy link
Contributor Author

bors r+

@newhoggy newhoggy force-pushed the newhoggy/use-environment-files-in-github-actions branch from 7a2e49a to 0dad76e Compare October 31, 2022 12:45
@newhoggy
Copy link
Contributor Author

newhoggy commented Nov 1, 2022

bors r+

@newhoggy newhoggy force-pushed the newhoggy/use-environment-files-in-github-actions branch from 0dad76e to adc3960 Compare November 7, 2022 08:02
@newhoggy newhoggy force-pushed the newhoggy/use-environment-files-in-github-actions branch from adc3960 to 8352376 Compare November 7, 2022 09:23
@newhoggy
Copy link
Contributor Author

newhoggy commented Nov 7, 2022

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 7, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 7ef8a73 into master Nov 7, 2022
@iohk-bors iohk-bors bot deleted the newhoggy/use-environment-files-in-github-actions branch November 7, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants