coot/small changes #4363
Merged
coot/small changes #4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coot
commented
Aug 19, 2022
coot
commented
- Removed runRunCommand
- Parsing of non-p2p topology file
- Remove unfinished handlePeersListSimple
The `liftIO` is a sophisticated identity function ;).
Make the non-p2p parsing API of the topology the same way as p2p one.
coot
requested review from
Jimbo4350,
newhoggy,
dcoutts,
erikd and
JaredCorduan
as code owners
newhoggy
approved these changes
Aug 20, 2022
coot
force-pushed
the
coot/small-changes
branch
from
56d46a5
to
fccd10a
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.