Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cardano-ledger and ouroboros-network dependencies #4118

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

newhoggy
Copy link
Contributor

No description provided.

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Soupstraw
Copy link
Contributor

Seems to be a duplicate of this: #4111

@newhoggy
Copy link
Contributor Author

newhoggy commented Jul 4, 2022

Sorry, didn't realise you were going to update node.

@newhoggy
Copy link
Contributor Author

newhoggy commented Jul 4, 2022

Also the necessary updates are merged into ouroboros-network, so it isn't necessary to use a fork anymore.

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the memory issue completely?

@newhoggy
Copy link
Contributor Author

newhoggy commented Jul 4, 2022

This doesn't fix the memory issue because the create-staked command hasn't yet switch to encode via toEncoding, but it's a necessary change.

@newhoggy newhoggy force-pushed the newhoggy/update-cardano-ledger-dependency branch from cffab23 to 6db19f2 Compare July 5, 2022 04:32
@newhoggy
Copy link
Contributor Author

newhoggy commented Jul 5, 2022

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 5, 2022
4118: Update cardano-ledger and ouroboros-network dependencies r=newhoggy a=newhoggy



Co-authored-by: John Ky <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 5, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from MarcFontaine, cleverca22, coot, deepfire, denisshevchenko, jutaro, and/or mgmeier.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

Copy link
Contributor

@MarcFontaine MarcFontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jimbo4350
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 5, 2022
4118: Update cardano-ledger and ouroboros-network dependencies r=Jimbo4350 a=newhoggy



Co-authored-by: John Ky <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 5, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from coot.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jimbo4350
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 5, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 3fca5ff into master Jul 5, 2022
@iohk-bors iohk-bors bot deleted the newhoggy/update-cardano-ledger-dependency branch July 5, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants