Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain lookup URL should include domains resource #120

Open
artur-intech opened this issue Oct 8, 2018 · 4 comments
Open

Domain lookup URL should include domains resource #120

artur-intech opened this issue Oct 8, 2018 · 4 comments

Comments

@artur-intech
Copy link
Contributor

/v1/domains/%domain% instead of v1/%domain%
@teadur
Copy link
Contributor

teadur commented Oct 8, 2018

Are we planning to share any other resources from rest-whois ?
I would unrestand the need for path change if thats the case.

@artur-intech
Copy link
Contributor Author

artur-intech commented Oct 8, 2018 •
edited
Loading

Having domains resource in the URL would document the intention more clearer. https://whois-api.example/v1/shop.example is less readable than https://whois-api.example/v1/domains/shop.example for a new user of API/developer, IMHO.

@teadur
Copy link
Contributor

teadur commented Oct 9, 2018 •
edited
Loading

as of 3rd partys are actively using the api we need to maintain the old paths aswell.
So im not sure if its worth it.

Maybe if we introduce new path as v2 ?

@artur-intech
Copy link
Contributor Author

artur-intech commented Oct 9, 2018 •
edited
Loading

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teadur @artur-intech