Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage columns: don't display empty fields #167

Open
sergiocontrino opened this issue Dec 19, 2018 · 11 comments
Open

manage columns: don't display empty fields #167

sergiocontrino opened this issue Dec 19, 2018 · 11 comments
Assignees

Comments

@sergiocontrino
Copy link
Member

manage columns displays also attributes with no data, not like the query builder default
see wormmine issue
https://github.com/WormBase/website/issues/6795

@yochannah yochannah transferred this issue from intermine/imjs Jan 3, 2019
@yochannah
Copy link
Member

yochannah commented Jan 3, 2019

@sergiocontrino fyi, migrated this ticket to im-tables as it's the repo where the visual component is managed. imjs is just the communication library

@sergiocontrino
Copy link
Member Author

oops..

@Dhruvi16
Copy link
Contributor

I would like to work on this.

@Emuohwo
Copy link

Emuohwo commented Mar 11, 2020

@sergiocontrino link to issue broken, kindly check it

@yochannah
Copy link
Member

Ooh, that is broken.

Dear @nuin - any idea what happened to the wormbase issue link?

@nuin
Copy link

nuin commented Mar 11, 2020

@yochannah Our issues are private now. I will paste the contents of the ticket

@nuin
Copy link

nuin commented Mar 11, 2020

This has caused quite a bit of confusion for several of our users (and myself):

The data model shown on the QueryBuilder page "Model browser" shows the attributes for the pertinent class that actually have data loaded. When a user runs a query and then explores the data model for the same class from the "Manage Columns" > "Add a Column" option, several additional attributes appear as options, all of which (so far as I can tell), have no data and are misleading. For example, the Gene class:

https://docs.google.com/presentation/d/13pgKFL-HrXkvw1Lm_Z1Nhm_X6tTXzT0z7KGhsjrWhy4/edit?usp=sharing

Comparing the two data models shown for the Gene class shows that the "Manage Columns" > "Add a Column" option shows 18 data and object properties that aren't available in the QueryBuilder "Model Browser" and all of which have no data associated.

I think it is important that we only show the valid attributes that have data in both views. We should eliminate the attributes in the "Manage Columns" > "Add a Column" view that have no data and are not present in the main model.

@yochannah
Copy link
Member

thanks @nuin!

@Dhruvi16 - I've assigned the issue to you, let us know if you have questions.

@Dhruvi16
Copy link
Contributor

Hey! I was able to reproduce the issue. But I am a little overwhelmed with the codebase and was not able to find where the list comes from. So can anyon ehelp me with this?
Thanks in advance.

@yochannah
Copy link
Member

@Dhruvi16
Copy link
Contributor

Dhruvi16 commented Mar 21, 2020

I do not think you got my question. So basically the list of 18 data and object properties are not static obviously. So I am unable to figure out where this list comes from. Could you please help me with that?
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants