Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download / Export link should not use an anchor tag. #156

Open
joshkh opened this issue Oct 26, 2015 · 8 comments
Open

Download / Export link should not use an anchor tag. #156

joshkh opened this issue Oct 26, 2015 · 8 comments
Labels

Comments

@joshkh
Copy link
Contributor

joshkh commented Oct 26, 2015

Exporting very large result sets can break because the download is done via an anchor tag and the URL can exceed maximum size.

Suggested fix: use blobs.

@joshkh joshkh added the bug label Oct 26, 2015
@joshkh joshkh self-assigned this Oct 26, 2015
@CodHeK
Copy link
Contributor

CodHeK commented Mar 9, 2019

Is this fixed, or can I take up this issue ?

@yochannah
Copy link
Member

@CodHeK this is definitely still present! It's probably okay to leave to be done as part of the GSoC project proposal though.

@Emmahchinonso
Copy link

@yochannah can i work on this as an outreachy contributor

@km-js
Copy link

km-js commented Mar 25, 2020

Hey @Emmahchinonso Are you still working on this?

@Emmahchinonso
Copy link

No pls

@km-js
Copy link

km-js commented Mar 28, 2020

Hey, @yochannah . I need a little briefing on this one??/

@yochannah
Copy link
Member

here's some technical context - I think we're using an <a> anchor tag to download results, but using a blob would be better : https://www.bennadel.com/blog/3472-downloading-text-using-blobs-url-createobjecturl-and-the-anchor-download-attribute-in-javascript.htm

the results tables (try choosing a template in flymine to bring up a results table) have an export function, which is where you will need to modify the code.

@oneshasappleton
Copy link

can I work on fixing this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants