Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bold letter warning to Readme that this has dangerous side effects #57

Open
kellyselden opened this issue Oct 7, 2016 · 1 comment
Open

Add bold letter warning to Readme that this has dangerous side effects #57

kellyselden opened this issue Oct 7, 2016 · 1 comment

Comments

@kellyselden
Copy link
Contributor

Relating to #41.

I tried to add this to a single spot in a large app to get fragment identifiers working. I didn't realize it was causing 404s in various locations because we still have some server rendered pages that are linked to, and we have a catchall route.
I didn't realize the initializer was handling all links, not just the one's I was modifying.
@kellyselden kellyselden mentioned this issue Oct 19, 2016
Open
@jlami jlami mentioned this issue May 23, 2017
Open
@danwenzel danwenzel mentioned this issue Apr 1, 2020
Open
@danwenzel
Copy link

Opened a PR to address this: #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kellyselden @danwenzel