Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderFieldsOnly): use prettier config #23

Merged
merged 2 commits into from
Apr 16, 2020

Conversation

zernie
Copy link
Contributor

@zernie zernie commented Mar 30, 2020

Use user's prettier config when --fields-only is enabled.


This change is Reviewable

@stevenpetryk
Copy link
Contributor

Do you have a need for this to be ran through prettier? At Intercom we're only using this for some validation in CI, so we're trying to keep the runtime as quick as possible. Happy to merge if you have a good use case for this though :)

@zernie
Copy link
Contributor Author

zernie commented Mar 31, 2020

@stevenpetryk I agree that it's not that important, this PR just makes --fields-only behave more like the default render. For a different approach, I think that adding a note about --fields-only not using prettier's config would be great

Copy link
Contributor

@stevenpetryk stevenpetryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I think it's fine to add. Prettier's pretty quick anyway.

@stevenpetryk stevenpetryk merged commit 683de80 into intercom:master Apr 16, 2020
@stevenpetryk
Copy link
Contributor

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants