This repository has been archived by the owner on Apr 23, 2019. It is now read-only.
Added "ruby" cookbook for maintaining binary ruby distribution #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| EOM | ||
| not_if { File.directory?(File.join('opt', 'rbenv', 'versions', ruby_version)) } | ||
| version, rbenv_versions_path = app_info[:ruby_version], "/opt/rbenv/versions" | ||
|
|
| let(:chef_run) { ChefSpec::SoloRunner.converge(described_recipe) } | ||
|
|
||
| it "installs ruby" do | ||
| expect(chef_run).to install_package("foo") |
There was a problem hiding this comment.
I think we need to actually test something here, right? :)
There was a problem hiding this comment.
Yes we do. I'm adding some meaningful tests right now
|
I just looked at the code quickly, overall it looks good. Did not try to run it though. Also I'm thinkin about the cookbook name. Maybe we should name it: intercity-ruby that way it wont collide with other cookbooks in the supermarket. @berkes What do you think about prefixing our cookbooks with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166