-
Notifications
You must be signed in to change notification settings - Fork 185
fix: 429 error not shown #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Toricane
merged 16 commits into
interactions-py:unstable
from
Toricane:fix-429-error-not-shown
Nov 4, 2022
Merged
fix: 429 error not shown #1125
Toricane
merged 16 commits into
interactions-py:unstable
from
Toricane:fix-429-error-not-shown
Nov 4, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EepyElvyra
reviewed
Oct 17, 2022
Contributor
Author
|
@EdVraz ready for review |
EepyElvyra
suggested changes
Oct 19, 2022
EepyElvyra
approved these changes
Nov 4, 2022
Contributor
EepyElvyra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request shows the 429 error properly.
I've been seeing lots of
JSONDecodeErrors from mostly Replit users (there is a documented case of it happening with Heroku as well), which leads to aTypeError. The common "fix" given to them was just to dokill 1in the shell with no additional information as to what happened and why.When I looked further into the code, I saw that when Cloudflare ratelimits you, it returns an HTML page instead of JSON, causing the
JSONDecodeError(because the library tries to JSONify the response immediately without any checks), which is typical for Replit users. The suggestion ofkill 1basically runs the code on a new server in Replit, sometimes with a new IP, so it temporarily works again.Ideally, this error shouldn't occur at all because the library handles ratelimits awesomely, but when it does occur, it isn't handled properly.
This PR highlights that it is a 429 error instead of not handling the exception.
Checklist
pre-commitcode linter has been run over all edited files to ensure the code is linted.3.8.6and higher.I've made this pull request: (check all that apply)
This is: