Skip to content

fix: fix DictSerializerMixin.update sets models into json #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Toricane merged 3 commits into from
Jul 22, 2022
Merged

fix: fix DictSerializerMixin.update sets models into json #948

Toricane merged 3 commits into from
Jul 22, 2022

Conversation

@Damego
Copy link
Member

@Damego Damego commented Jul 20, 2022

About

This pull request:

  1. Fixes setting dataclass model into json in DictSerializerMixin.update.
  2. Reverts fix: Fix item assign error dynamically. #947 because this issue fixed by №1.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@EepyElvyra EepyElvyra enabled auto-merge (squash) July 20, 2022 10:28
@Damego Damego disabled auto-merge July 20, 2022 10:28
Toricane
Toricane approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Toricane Toricane merged commit b0001f7 into interactions-py:unstable Jul 22, 2022
@Damego Damego mentioned this pull request Jul 26, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Toricane Toricane Toricane approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Damego @Toricane