Skip to content

Conversation

@Damego
Copy link
Member

@Damego Damego commented Jan 23, 2023

About

This pull request moves on_command event dispatching to other place where command's func is called. Resolves #1133

Checklist

  • The pre-commit code linter has been run over all edited files to ensure the code is linted.
  • I've ensured the change(s) work on 3.8.6 and higher.
  • I have added the versionadded, versionchanged and deprecated to any new or changed user-facing function I committed.

Pull-Request specification

I've made this pull request: (check all that apply)

This is:

  • A breaking change

@Damego Damego linked an issue Jan 23, 2023 that may be closed by this pull request
1 task
@Damego Damego added the bug Something isn't working label Jan 23, 2023
@Damego Damego requested a review from Catalyst4222 January 24, 2023 13:03
@Damego Damego merged commit 2c3ffa3 into interactions-py:unstable Feb 3, 2023
@Damego Damego deleted the move-on_command-dispatch-to-command-class branch February 3, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Context is missing command attribute in the on_component event

3 participants