Skip to content

Conversation

@FayeDel
Copy link
Collaborator

@FayeDel FayeDel commented Dec 17, 2022

About

This pull request implements Linked Roles connection support.

Checklist

  • The pre-commit code linter has been run over all edited files to ensure the code is linted.
  • I've ensured the change(s) work on 3.8.6 and higher.

I've made this pull request: (check all that apply)

  • For the documentation
  • To add a new feature
  • As a general enhancement
  • As a refactor of the library/the library's code
  • To fix an existing bug
  • To resolve #ISSUENUMBER

This is:

  • A breaking change

Copy link
Member

@Damego Damego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Damego Damego added the enhancement New feature or request label Dec 18, 2022
Copy link
Member

@Damego Damego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed return typehints

@FayeDel FayeDel requested a review from Damego December 18, 2022 14:55
@FayeDel FayeDel enabled auto-merge (squash) December 18, 2022 14:55
@FayeDel FayeDel merged commit fe64d11 into interactions-py:unstable Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants