Skip to content

fix: Message.referenced_message returns wrong data #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FayeDel merged 3 commits into from
Dec 11, 2022
Merged

fix: Message.referenced_message returns wrong data #1191

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81f5e3f
fix: `Message.referenced_message` returns wrong data
Damego Dec 7, 2022
ae37057
docs: wrong docstring
Damego Dec 7, 2022
8a4a154
fix: cannot convert message
Damego Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions interactions/api/models/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,8 @@ class Message(ClientSerializerMixin, IDMixin):
:ivar Optional[MessageActivity] activity: Message activity object that's sent by Rich Presence
:ivar Optional[Application] application: Application object that's sent by Rich Presence
:ivar Optional[MessageReference] message_reference: Data showing the source of a message (crosspost, channel follow, add, pin, or replied message)
:ivar int flags: Message flags
:ivar Optional[MessageFlags] flags: Message flags
:ivar Optional[Message] referenced_message: The message associated with the message_reference.
:ivar Optional[MessageInteraction] interaction: Message interaction object, if the message is sent by an interaction.
:ivar Optional[Channel] thread: The thread that started from this message, if any, with a thread member object embedded.
:ivar Optional[List[ActionRow]] components: Array of Action Rows associated with this message, if any.
Expand Down Expand Up @@ -724,8 +725,8 @@ class Message(ClientSerializerMixin, IDMixin):
application: Optional[Application] = field(converter=Application, default=None)
application_id: Optional[Snowflake] = field(converter=Snowflake, default=None)
message_reference: Optional[MessageReference] = field(converter=MessageReference, default=None)
flags: Optional[Union[int, MessageFlags]] = field(converter=MessageFlags, default=None)
referenced_message: Optional[MessageReference] = field(converter=MessageReference, default=None)
flags: Optional[MessageFlags] = field(converter=MessageFlags, default=None)
referenced_message: Optional["Message"] = field(default=None)
interaction: Optional[MessageInteraction] = field(
converter=MessageInteraction, default=None, add_client=True, repr=False
)
Expand Down Expand Up @@ -756,6 +757,9 @@ def __attrs_post_init__(self):
if self.author and self.member:
self.member.user = self.author

if self.referenced_message is not None:
self.referenced_message = Message(**self.referenced_message, _client=self._client)

async def get_channel(self) -> Channel:
"""
.. versionadded:: 4.0.2
Expand Down