fix: Ignore undeletable messages in channel.purge; fix rate-limits issue. #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EepyElvyra
requested review from
AstreaTSS,
Catalyst4222,
Damego,
FayeDel and
Toricane
EepyElvyra
commented
Nov 25, 2022
Damego
reviewed
Nov 26, 2022
Damego
approved these changes
Nov 26, 2022
|
Hm. Seems like this didn't fix the bug. I'm still encountering ratelimits when the bot tries to delete undeletable messages. Version 4.3.4 |
Member
v4.3.4 was released in october, 26. This pr was merged november, 26. How it's supposed to appears in v4.3.4? You can install v4.4.0 beta or wait for new release. |
|
Whoops. I admittedly didn't check, I just assumed that a 3-month old PR would have made it to main by now. My bad. Used a lambda to get around it in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
see title.
Checklist
pre-commitcode linter has been run over all edited files to ensure the code is linted.3.8.6and higher.I've made this pull request: (check all that apply)
This is: