Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone or send SMS message support for phone numbers #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Phone or send SMS message support for phone numbers #55

wants to merge 1 commit into from

Conversation

RustyKnight
Copy link

Adding Phone/Message support via "sendMessage" which takes a phone number and allows user to select to either send a message (SMS) or call the number.

Currently no validation on the number is performed to determine if the number is a mobile number or not

…mber and allows user to select to either send a message (SMS) or call the number.

Currently no validation on the number is performed to determine if the number is a mobile number or not
@RustyKnight
Copy link
Author

Simply uses the "telprompt://" and "sms://" urls to either open the phone or sms apps.

This means that, unfortunately, it will only work on an actual device

@lazerwalker
Copy link
Member

First of all, thanks so much for this!

That being said, I'm conflicted about where this fits into IntentKit. Being able to tap a phone number and get a pop-up asking if you want to call it or send an SMS to it seems valuable, and mirrors functionality provided in the Contacts/Messages app in a useful way. Generally, though, IntentKit handlers operate on the principle of "given a specific action you want to take [e.g. send an email], here are multiple ways to perform that action". This is "given a specific object [a phone number], here are a few different actions you can take on it".

For the purposes of keeping IntentKit a cohesive library, I'd be much more inclined to have two separate handlers, one for making phone calls (ideally with additional support to call a phone number from Skype/Google Voice/etc) and one for sending SMS messages (with support for a sms:// URL, MFMessageComposeViewController via modal dialog, third-party apps like WhatsApp, etc).

I'm going to muse this over. Great work, though, and thanks again!

@RustyKnight
Copy link
Author

The motivation behind the idea is simply this. I need to present a
phone number to the user, I don't always want to phone the number and don't
always want to message the number, but I typically want to either.

Rather then needing to supply a "phone" OR "message" option to the user,
which could clutter the UI, the intent kit seemed to fit the scope of
providing the user with a common selection mechanism

I don't disagree with the extended support of things like Skype/Google
voice/face time/etc, I simply don't have them installed ;)

On Wednesday, 20 May 2015, Mike [email protected] wrote:

First of all, thanks so much for this!

That being said, I'm conflicted about where this fits into IntentKit.
Being able to tap a phone number and get a pop-up asking if you want to
call it or send an SMS to it seems valuable, and mirrors functionality
provided in the Contacts/Messages app in a useful way. Generally, though,
IntentKit handlers operate on the principle of "given a specific action you
want to take [e.g. send an email], here are multiple ways to perform that
action". This is "given a specific object [a phone number], here are a few
different actions you can take on it".

For the purposes of keeping IntentKit a cohesive library, I'd be much more
inclined to have two separate handlers, one for making phone calls (ideally
with additional support to call a phone number from Skype/Google Voice/etc)
and one for sending SMS messages (with support for a sms:// URL,
MFMessageComposeViewController via modal dialog, third-party apps like
WhatsApp, etc).

I'm going to muse this over. Great work, though, and thanks again!


Reply to this email directly or view it on GitHub
#55 (comment).

@RustyKnight
Copy link
Author

"Thoughts"

Okay, we could have separate handlers for "phone" (with "call" selector)
and "message" (with "sendMessage" selector), but it should also be possible
to have a common "communicateWith" selector (for example), which allow both
to be presented.

This provides the intent that we want the user to have the option to make
the choices over "how" they want to communicate with the value at hand.

It should also be possible to included "contacts" as well (add to contacts)

This would then extend to email addresses, where you can use things like
skype, messanger, email, etc, but without needing to always present them.

I'd also like to see the inclusion of a "copy" option as a "extra
optional", so you could copy the "value" to the clipboard (use this a lot
with the activity sheet)

On Wed, May 20, 2015 at 7:49 AM, Shane Whitehead [email protected] wrote:

The motivation behind the idea is simply this. I need to present a
phone number to the user, I don't always want to phone the number and don't
always want to message the number, but I typically want to either.

Rather then needing to supply a "phone" OR "message" option to the user,
which could clutter the UI, the intent kit seemed to fit the scope of
providing the user with a common selection mechanism

I don't disagree with the extended support of things like Skype/Google
voice/face time/etc, I simply don't have them installed ;)

On Wednesday, 20 May 2015, Mike [email protected] wrote:

First of all, thanks so much for this!

That being said, I'm conflicted about where this fits into IntentKit.
Being able to tap a phone number and get a pop-up asking if you want to
call it or send an SMS to it seems valuable, and mirrors functionality
provided in the Contacts/Messages app in a useful way. Generally, though,
IntentKit handlers operate on the principle of "given a specific action you
want to take [e.g. send an email], here are multiple ways to perform that
action". This is "given a specific object [a phone number], here are a few
different actions you can take on it".

For the purposes of keeping IntentKit a cohesive library, I'd be much
more inclined to have two separate handlers, one for making phone calls
(ideally with additional support to call a phone number from Skype/Google
Voice/etc) and one for sending SMS messages (with support for a sms://
URL, MFMessageComposeViewController via modal dialog, third-party apps
like WhatsApp, etc).

I'm going to muse this over. Great work, though, and thanks again!


Reply to this email directly or view it on GitHub
#55 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants