-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phone or send SMS message support for phone numbers #55
base: master
Are you sure you want to change the base?
Conversation
…mber and allows user to select to either send a message (SMS) or call the number. Currently no validation on the number is performed to determine if the number is a mobile number or not
Simply uses the "telprompt://" and "sms://" urls to either open the phone or sms apps. This means that, unfortunately, it will only work on an actual device |
First of all, thanks so much for this! That being said, I'm conflicted about where this fits into IntentKit. Being able to tap a phone number and get a pop-up asking if you want to call it or send an SMS to it seems valuable, and mirrors functionality provided in the Contacts/Messages app in a useful way. Generally, though, IntentKit handlers operate on the principle of "given a specific action you want to take [e.g. send an email], here are multiple ways to perform that action". This is "given a specific object [a phone number], here are a few different actions you can take on it". For the purposes of keeping IntentKit a cohesive library, I'd be much more inclined to have two separate handlers, one for making phone calls (ideally with additional support to call a phone number from Skype/Google Voice/etc) and one for sending SMS messages (with support for a I'm going to muse this over. Great work, though, and thanks again! |
The motivation behind the idea is simply this. I need to present a Rather then needing to supply a "phone" OR "message" option to the user, I don't disagree with the extended support of things like Skype/Google On Wednesday, 20 May 2015, Mike [email protected] wrote:
|
"Thoughts" Okay, we could have separate handlers for "phone" (with "call" selector) This provides the intent that we want the user to have the option to make It should also be possible to included "contacts" as well (add to contacts) This would then extend to email addresses, where you can use things like I'd also like to see the inclusion of a "copy" option as a "extra On Wed, May 20, 2015 at 7:49 AM, Shane Whitehead [email protected] wrote:
|
Adding Phone/Message support via "sendMessage" which takes a phone number and allows user to select to either send a message (SMS) or call the number.
Currently no validation on the number is performed to determine if the number is a mobile number or not