Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request for "Print" option #8

Open
ghanshyam-1805 opened this issue Oct 28, 2020 · 7 comments
Open

Feature request for "Print" option #8

ghanshyam-1805 opened this issue Oct 28, 2020 · 7 comments

Comments

@ghanshyam-1805
Copy link

ghanshyam-1805 commented Oct 28, 2020

Is possible to add a print option in the toolbox?

@trinhngocdieu
Copy link
Contributor

hi @ghanshyam-1805 ,
yes, it is possible, but right now our react-pdf has had it yet.
How about we provide an option to add a print icon?
When the user clicks on the print icon, we will save that pdf to your device?

@ghanshyam-1805
Copy link
Author

ghanshyam-1805 commented Oct 29, 2020

There will be good if the native print popup will be open on click of the print icon, the Download option will be a new feature if anyone required.

@ghanshyam-1805
Copy link
Author

ghanshyam-1805 commented Oct 29, 2020

@trinhngocdieu What's your suggestion?

@trinhngocdieu
Copy link
Contributor

@ghanshyam-1805 , sorry for late response.
I think it is possible, I will update and let you know soon.

@ghanshyam-1805
Copy link
Author

ghanshyam-1805 commented Oct 30, 2020

@trinhngocdieu Thanks.

@ghanshyam-1805
Copy link
Author

ghanshyam-1805 commented Oct 31, 2020

@trinhngocdieu I have found one issue and enhancement,

  1. Zoom issue: When we continuously press the "zoom-out" button it throws an error in the console that "PDFViewer._setScale: "-0.19999999999999996" is an unknown zoom value." and PDF got invisible.
  2. Enhancement: While scrolling the PDF, thumbnails should also scroll according to the page.

It would be great if you look at these also.

Thanks!

@trinhngocdieu
Copy link
Contributor

@ghanshyam-1805 : Thank you so much, I will try to look and fix them soon.
It would be great if you can create a PR, too! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants