This repository was archived by the owner on Mar 5, 2024. It is now read-only.
Fix incorrect buffer size #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When decrypting with CBC mode, the in and out buffers should be the same size. Even though the IV and ciphertext are contiguous, the in buffer points to the first byte of the ciphertext. The sanity check has been updated accordingly. Because of this error, the CBC mode tests are reporting the wrong size for the decrypted buffer (80 - 16 - 16 == 48 != 64). This has been corrected. Also, since the loop in the decryption is writing to the out buffer, the loop conditional has been changed to `n < outlen`. This should avoid any future errors if `inlen` changes so that it’s no longer equal to `outlen`.
Contributor
|
Many thanks for the patch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decrypting with CBC mode, the in and out buffers should be the same size. Even though the IV and ciphertext are contiguous, the in buffer points to the first byte of the ciphertext. The sanity check has been updated accordingly.
Because of this error, the CBC mode tests are reporting the wrong size for the decrypted buffer (80 - 16 - 16 == 48 != 64). This has been corrected.
Also, since the loop in the decryption is writing to the out buffer, the loop conditional has been changed to
n < outlen. This should avoid any future errors ifinlenchanges so that it’s no longer equal tooutlen.