Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine matToBlob function from derived classes to BaseModel #286

Open
gitpqLee opened this issue Apr 24, 2023 · 2 comments
Open

Refine matToBlob function from derived classes to BaseModel #286

gitpqLee opened this issue Apr 24, 2023 · 2 comments
Labels
good first issue Good for newcomers hackathon For hachathon/tests

Comments

@gitpqLee
Copy link
Contributor

gitpqLee commented Apr 24, 2023

Currently, in ObjectDetectionModel , the virtual function matToBlob has no implementation and each derived classes have their own implemantation.
We want to refine the common function to the ObjectDetectionModel or BaseModel. For the model specific pre-process, we can use some functions to implemente which can be overrideed. For example:

bool matToBlob (...) {
      [some common implementation];
      func_1();
      func_2();
}

func_1() / func_2() can be overrideed by derived model classes and implement some model specific pre-process logic.

@LewisLiuPub LewisLiuPub added good first issue Good for newcomers hackathon For hachathon/tests labels Apr 24, 2023
@ChloeWu1
Copy link
Contributor

ROS_Team2 working on this issue.

@ChloeWu1
Copy link
Contributor

Please review #289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hackathon For hachathon/tests
Projects
None yet
Development

No branches or pull requests

3 participants