Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up error codes #510

Open
pohly opened this issue Jan 10, 2020 · 0 comments
Open

clean up error codes #510

pohly opened this issue Jan 10, 2020 · 0 comments
Labels
future needs to be fixed in some future release

Comments

@pohly
Copy link
Contributor

pohly commented Jan 10, 2020

https://github.com/kubernetes/kubernetes/blob/ca532c6fb2c08f859eca13e0557f3b2aec9a18e0/pkg/volume/csi/csi_client.go#L627-L649 lists the error code that cause Kubernetes to retry an operation.

We often just return InternalError when some operation failed, for example in https://github.com/kubernetes/kubernetes/blob/ca532c6fb2c08f859eca13e0557f3b2aec9a18e0/pkg/volume/csi/csi_client.go#L627-L649

InternalError is a final error, which may or may not be correct here. We should check the errno and only return a final error when we don't expect that the problem will ever go away.

@pohly pohly added the future needs to be fixed in some future release label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future needs to be fixed in some future release
Projects
None yet
Development

No branches or pull requests

1 participant