Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up after failure #508

Open
pohly opened this issue Jan 10, 2020 · 0 comments
Open

clean up after failure #508

pohly opened this issue Jan 10, 2020 · 0 comments
Labels
future needs to be fixed in some future release

Comments

@pohly
Copy link
Contributor

pohly commented Jan 10, 2020

As discussed in https://kubernetes.slack.com/archives/C8EJ01Z46/p1578650595018200, CSI methods like CreateVolume and NodePublishVolume must clean up when they return a "final" error (as defined in https://github.com/kubernetes/kubernetes/blob/ca532c6fb2c08f859eca13e0557f3b2aec9a18e0/pkg/volume/csi/csi_client.go#L627-L649) because Kubernetes will give up calling them and also not call the corresponding DeleteVolume and NodeUnpublishVolume methods.

For example, an ephemeral volume currently leaks when formatting or mounting it fails.
@pohly pohly added the future needs to be fixed in some future release label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
future needs to be fixed in some future release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pohly