Skip to content

Lint Bug fix for Session Option Append Execution Provider #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfatimar merged 3 commits into from
Mar 18, 2025
Merged

Lint Bug fix for Session Option Append Execution Provider #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8913d4d
Commit Lint Errors fix
sfatimar Mar 3, 2025
c8d7fff
Merge branch 'ovep-develop' into sahar/session_option_bug_fix
sfatimar Mar 12, 2025
e067934
Merge branch 'ovep-develop' into sahar/session_option_bug_fix
sfatimar Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions onnxruntime/core/providers/openvino/openvino_provider_factory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
namespace onnxruntime {
namespace openvino_ep {
void ParseConfigOptions(ProviderInfo& pi) {
if (pi.config_options == NULL)

if (pi.config_options == nullptr)
return;

pi.so_disable_cpu_ep_fallback = pi.config_options->GetConfigOrDefault(kOrtSessionOptionsDisableCPUEPFallback, "0") == "1";
Expand Down Expand Up @@ -149,15 +150,9 @@ struct OpenVINO_Provider : Provider {
}

std::array<void*, 2> pointers_array = *reinterpret_cast<const std::array<void*, 2>*>(void_params);
const ProviderOptions* provider_options_ptr = reinterpret_cast<ProviderOptions*>(pointers_array[0]);
const ProviderOptions provider_options = *reinterpret_cast<ProviderOptions*>(pointers_array[0]);
const ConfigOptions* config_options = reinterpret_cast<ConfigOptions*>(pointers_array[1]);

if (provider_options_ptr == NULL) {
LOGS_DEFAULT(ERROR) << "[OpenVINO EP] Passed NULL ProviderOptions to CreateExecutionProviderFactory()";
return nullptr;
}
const ProviderOptions provider_options = *provider_options_ptr;

ProviderInfo pi;
pi.config_options = config_options;

Expand Down
2 changes: 1 addition & 1 deletion onnxruntime/core/session/provider_bridge_ort.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2020,7 +2020,7 @@ std::shared_ptr<IExecutionProviderFactory> OpenVINOProviderFactoryCreator::Creat
const ProviderOptions* provider_options_map, const SessionOptions* session_options) {
// Append session options applicable for EP to EP Provider options.
const ConfigOptions* config_options = nullptr;
if (session_options !=nullptr) {
if (session_options != nullptr) {
config_options = &session_options->config_options;
}

Expand Down
Loading