[SYCL] Fix accessor CTAD for unittests #7638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessor CTAD would in certain cases fail to resolve IsValidTag and IsSameAsBuffer. This commit fixes this issue by making these trait structs rather than constexpr functions. Signed-off-by: Larsen, Steffen <[email protected]>
Contributor
|
Was the issue compiler-specific? |
aelovikov-intel
approved these changes
Dec 5, 2022
Contributor
Author
I am not sure, but I'd argue this is an improvement in general. |
Contributor
Author
|
Failures on HIP tracked by #7634. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessor CTAD would in certain cases fail to resolve IsValidTag and IsSameAsBuffer. This commit fixes this issue by making these trait structs rather than constexpr functions.