[SYCL] Omit TemplatedDecl from int-footer for a VarTemplateDecl #4108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hook we had always added the VarDecl when it was visited, however when evaluating a VarTemplateDecl, Clang creates a VarDecl to represent the declaration as a child of the VarTemplateDecl. We don't need to capture it in our collection since the VarTemplateSpecializationDecl will provide the info we need. If we DON'T do this, we end up having 2 specializations for the specialization_id, one of which is invalid.
erichkeane
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
elizabethandrews
approved these changes
Jul 14, 2021
Contributor
|
The Jenkins failure appears to be an unrelated timeout, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hook we had always added the VarDecl when it was visited, however
when evaluating a VarTemplateDecl, Clang creates a VarDecl to represent
the declaration as a child of the VarTemplateDecl. We don't need to
capture it in our collection since the VarTemplateSpecializationDecl
will provide the info we need.
If we DON'T do this, we end up having 2 specializations for the
specialization_id, one of which is invalid.