[SYCL][PI][L0] ZeSerialize false race fix #2672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull to update my local fork
updating fork from main
update fork to sycl head
Update my fork
Updating fork to head of sycl.
… that Intel Inspector race condition detector doesn't think there is a race that can occur when writing ZeSerialize on one thread while reading it on another. There was never really a race before because all threads would write the same value, and thus there was no issue. But this way of writing the code removes the false race, and makes it obvious this global variable can only be initialized once.
bader
changed the title
smaslov-intel
approved these changes
Oct 23, 2020
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
…d-0.11.0-dev2 common: Bump UMF version to v0.11.0-dev2
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
…1.0-dev2 common: Bump UMF version to v0.11.0-dev2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to the way ZeSerialize is initialized. This change makes it so that Intel Inspector race condition detector doesn't think there is a race that can occur when writing ZeSerialize on one thread while reading it on another. There was never really a race before because all threads would write the same value, and thus there was no issue. But this way of writing the code removes the false race, and makes it obvious this global variable can only be initialized once.