[SYCL][CUDA][WIP] Implemented CUDA pi_sampler #1955
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary memory fence after a CUDA memory barrier (__syncthreads). The emitted `bar.sync 0` PTX instruction ensures that all memory accesses of threads involved in the barrier `0` have been performed and that no new memory accesses happen before the barrier completes. The removed memory fence reduced performance without adding any functionality to the barrier memory behavior. Signed-off-by: Bjoern Knafla <[email protected]> Co-authored-be: Victor Lomuller <[email protected]>
Remove old forward declared SPIR-V builtin from the relational category. Update the binding file using the header generator. Add relevant binding test. Remove XFAIL from related SYCL tests. Signed-off-by: Victor Lomuller <[email protected]>
nyalloc
changed the title
nyalloc
changed the title
nyalloc
changed the title
nyalloc
changed the title
Contributor
|
@smaslov-intel, @intel/llvm-reviewers-cuda, ping. |
nyalloc
changed the title
bb-sycl
pushed a commit
that referenced
this pull request
Apr 18, 2023
I forgot to update this in KhronosGroup/SPIRV-LLVM-Translator@0ef30a3 Signed-off-by: Sarnie, Nick <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@664097f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an implementation of the
pi_samplerAPI for the PI CUDA backend.