[SYCL] Use inline in device definition of _invalid_parameter
#18451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
approved these changes
May 13, 2025
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
May 14, 2025
aelovikov-intel
requested changes
May 14, 2025
Contributor
aelovikov-intel
left a comment
aelovikov-intel
left a comment
There was a problem hiding this comment.
I thought this version doesn't help with the error downstream... Ian, can you confirm it's fixed?
Contributor
Author
|
@aelovikov-intel This was the version that fixed the downstream kmeans build failures, I later realized me not being able to replicate was because of my environment. I am testing to see if this'll also fix post commit: https://github.com/intel/llvm/actions/runs/15026620724 |
Contributor
Author
|
@aelovikov-intel Are changes still needed here? |
aelovikov-intel
approved these changes
May 16, 2025
KornevNikita
pushed a commit
that referenced
this pull request
May 27, 2025
) Header definitions should be `inline` to avoid multiple definitions error. --------- Co-authored-by: aelovikov-intel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header definitions should be
inlineto avoid multiple definitions error.