Revert "[lldb] Fix dynamic_cast by no longer failing on variable without metadata"

This reverts commit b448d1b.

llvm-svn: 368615

Author: sstamenova

lldb/packages/Python/lldbsuite/test/lang/cpp/dynamic_cast/ExtBase.cpp

@@ -1265,10 +1265,16 @@ bool IRForTarget::MaybeHandleVariable(Value *llvm_value_ptr) {
     clang::NamedDecl *named_decl = DeclForGlobal(global_variable);
 
     if (!named_decl) {
+      if (IsObjCSelectorRef(llvm_value_ptr))
+        return true;
+
+      if (!global_variable->hasExternalLinkage())
+        return true;
+
       LLDB_LOG(log, "Found global variable \"{0}\" without metadata",
                global_variable->getName());
 
-      return true;
+      return false;
     }
 
     llvm::StringRef name(named_decl->getName());