Remove assert statement to allow for multiple decorations on a given pointer (#1952)

asudarsa · againull · commit 2b4bee357115 · 2023-04-17T10:01:44.000-07:00
Signed-off-by: Arvind Sudarsanam <arvind.sudarsanam@intel.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@373d46c
diff --git a/llvm-spirv/lib/SPIRV/SPIRVReader.cpp b/llvm-spirv/lib/SPIRV/SPIRVReader.cpp
@@ -1257,10 +1257,8 @@ static void replaceOperandWithAnnotationIntrinsicCallResult(Function *F,
     for (auto *Use : BV->users()) {
       if (auto *II = dyn_cast<IntrinsicInst>(Use)) {
         if (II->getIntrinsicID() == Intrinsic::ptr_annotation &&
-            II->getType() == BV->getType()) {
-          assert(CR == nullptr && "Multiple annotation created for same value");
+            II->getType() == BV->getType())
           CR = II;
-        }
       }
     }
     return CR ? true : false;

Original file line number	Diff line number	Diff line change
`@@ -1257,10 +1257,8 @@ static void replaceOperandWithAnnotationIntrinsicCallResult(Function *F,`
`1257`	`1257`	`for (auto *Use : BV->users()) {`
`1258`	`1258`	`if (auto *II = dyn_cast<IntrinsicInst>(Use)) {`
`1259`	`1259`	`if (II->getIntrinsicID() == Intrinsic::ptr_annotation &&`
`1260`		`- II->getType() == BV->getType()) {`
`1261`		`- assert(CR == nullptr && "Multiple annotation created for same value");`
	`1260`	`+ II->getType() == BV->getType())`
`1262`	`1261`	`CR = II;`
`1263`		`- }`
`1264`	`1262`	`}`
`1265`	`1263`	`}`
`1266`	`1264`	`return CR ? true : false;`