[SYCL] Deprecate unintentionally public property_list APIs (#19789)

The implementation of SYCL property_list unintentionally exposed
add_or_replace_accessor_properties and delete_accessor_property, despite
the APIs not being part of the specification nor any extensions. This
commite deprecates them and removes them under preview.

---------

Signed-off-by: Larsen, Steffen <[email protected]>

Author: steffenlarsen

sycl/include/sycl/property_list.hpp

@@ -25,6 +25,7 @@ template <typename... PropsT> class accessor_property_list;
 } // namespace ext::oneapi
 namespace detail {
 class PropertyValidator;
+class SYCLMemObjT;
 } // namespace detail
 
 /// Objects of the property_list class are containers for the SYCL properties
@@ -58,15 +59,28 @@ class property_list : protected detail::PropertyListBase {
     return has_property_helper<PropT>();
   }
 
+  template <typename... T> operator ext::oneapi::accessor_property_list<T...>();
+
+#ifdef __INTEL_PREVIEW_BREAKING_CHANGES
+private:
+#endif
+
+#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
+  __SYCL_DEPRECATED("add_or_replace_accessor_properties() is not part of the "
+                    "SYCL API and will be removed in the future.")
+#endif
   void add_or_replace_accessor_properties(const property_list &PropertyList) {
     add_or_replace_accessor_properties_helper(PropertyList.MPropsWithData);
   }
+
+#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
+  __SYCL_DEPRECATED("delete_accessor_property() is not part of the SYCL API "
+                    "and will be removed in the future.")
+#endif
   void delete_accessor_property(const sycl::detail::PropWithDataKind &Kind) {
     delete_accessor_property_helper(Kind);
   }
 
-  template <typename... T> operator ext::oneapi::accessor_property_list<T...>();
-
 private:
   property_list(
       std::bitset<detail::DataLessPropKind::DataLessPropKindSize> DataLessProps,
@@ -76,6 +90,7 @@ class property_list : protected detail::PropertyListBase {
   template <typename... PropsT>
   friend class ext::oneapi::accessor_property_list;
   friend class detail::PropertyValidator;
+  friend class detail::SYCLMemObjT;
 };
 
 namespace detail {

sycl/test/warnings/warnings_deprecated.cpp

@@ -11,5 +11,13 @@ int main() {
   // expected-warning@+2{{'discard_events' is deprecated: use sycl_ext_oneapi_enqueue_functions instead}}
   sycl::property_list props{
       sycl::ext::oneapi::property::queue::discard_events{}};
+
+  // expected-warning@+1{{add_or_replace_accessor_properties() is not part of the SYCL API and will be removed in the future.}}
+  props.add_or_replace_accessor_properties(props);
+
+  // expected-warning@+1{{delete_accessor_property() is not part of the SYCL API and will be removed in the future.}}
+  props.delete_accessor_property(
+      sycl::detail::PropWithDataKind::BufferUseMutex);
+
   return 0;
 }