From 73032358b9da4fbb3918a78242c2ac19b792f39a Mon Sep 17 00:00:00 2001 From: Alexey Bader Date: Wed, 22 Dec 2021 20:00:32 +0300 Subject: [PATCH 1/2] Fix test disabling "UNSUPPORTED: TEMPORARY_DISABLED" doesn't really disables the test. "REQUIRES: TEMPORARY_DISABLED" disables because test requires feature, which is not enabled. --- SYCL/Basic/get_backend.cpp | 2 +- SYCL/ESIMD/fp_call_from_func.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/SYCL/Basic/get_backend.cpp b/SYCL/Basic/get_backend.cpp index 651eb7a08292..9fbddaf1ecee 100644 --- a/SYCL/Basic/get_backend.cpp +++ b/SYCL/Basic/get_backend.cpp @@ -1,4 +1,4 @@ -// UNSUPPORTED: TEMPORARY_DISABLED +// REQUIRES: TEMPORARY_DISABLED // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out // RUN: env SYCL_DEVICE_FILTER=%sycl_be %t.out // diff --git a/SYCL/ESIMD/fp_call_from_func.cpp b/SYCL/ESIMD/fp_call_from_func.cpp index dec41df4a6c2..7babd49a1f59 100644 --- a/SYCL/ESIMD/fp_call_from_func.cpp +++ b/SYCL/ESIMD/fp_call_from_func.cpp @@ -7,7 +7,7 @@ //===----------------------------------------------------------------------===// // REQUIRES: gpu // Issue #162 Test timeouts on Windows and Linux -// UNSUPPORTED: TEMPORARY_DISABLED +// REQUIRES: TEMPORARY_DISABLED // RUN: %clangxx -Xclang -fsycl-allow-func-ptr -fsycl %s -o %t.out // RUN: %GPU_RUN_PLACEHOLDER %t.out // UNSUPPORTED: cuda || hip From 721afa44c7f7255aa6441d2c759c1d88c0f6819b Mon Sep 17 00:00:00 2001 From: Alexey Bader Date: Thu, 23 Dec 2021 10:03:38 +0300 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: vladimirlaz --- SYCL/Basic/get_backend.cpp | 2 +- SYCL/ESIMD/fp_call_from_func.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/SYCL/Basic/get_backend.cpp b/SYCL/Basic/get_backend.cpp index 9fbddaf1ecee..d64aa6553a83 100644 --- a/SYCL/Basic/get_backend.cpp +++ b/SYCL/Basic/get_backend.cpp @@ -1,6 +1,6 @@ // REQUIRES: TEMPORARY_DISABLED // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out -// RUN: env SYCL_DEVICE_FILTER=%sycl_be %t.out +// RUN: %t.out // //==----------------- get_backend.cpp ------------------------==// // This is a test of get_backend(). diff --git a/SYCL/ESIMD/fp_call_from_func.cpp b/SYCL/ESIMD/fp_call_from_func.cpp index 7babd49a1f59..6f4b03d91009 100644 --- a/SYCL/ESIMD/fp_call_from_func.cpp +++ b/SYCL/ESIMD/fp_call_from_func.cpp @@ -6,7 +6,7 @@ // //===----------------------------------------------------------------------===// // REQUIRES: gpu -// Issue #162 Test timeouts on Windows and Linux +// Issue #163 Test timeouts on Windows and Linux // REQUIRES: TEMPORARY_DISABLED // RUN: %clangxx -Xclang -fsycl-allow-func-ptr -fsycl %s -o %t.out // RUN: %GPU_RUN_PLACEHOLDER %t.out