va/va_trace: unbreak Linux with glibc >= 2.30 #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glibc could probably use `__GLIBC_PREREQ(2, 30)` but musl doesn't expose version to consumers. Instead of dancing around various libc always use local definition.
jbeich
changed the title
Contributor
|
@uartie : was Fedora build issue same as on Ubuntu? |
Contributor
|
Works for me on Ubuntu 20.04. |
dvrogozh
approved these changes
Oct 16, 2020
Contributor
|
Works for me on Fedora 32 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed by 9ab7db3 and glibc@1d0fc213824e and musl@d49cf07541bb.
Fixes #363 (comment).
TravisCI +
dist: focalresults: before, after.