Skip to content

Conversation

@iarebatman
Copy link

These allow a clean, functional build on OpenBSD 6.6.
OpenBSD doesn't provide the same mechanism to get the
current thread id. Move existing TID references into
a new function get_pid_t and implement specifics there.

These allow a clean, functional build on OpenBSD 6.6.
OpenBSD doesn't provide the same mechanism to get the
current thread id. Move existing TID references into
a new function get_pid_t and implement specifics there.
Copy link
Contributor

@dvrogozh dvrogozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was that previously done by some custom patch during BSD packaging? If yes, can you, please, provide a link to the packaging scripts?

@iarebatman
Copy link
Author

Was that previously done by some custom patch during BSD packaging? If yes, can you, please, provide a link to the packaging scripts?

It is not currently in the OpenBSD ports system. I'm currently putting a new port together and this
is my own patch.

@dvrogozh
Copy link
Contributor

@iarebatman : thank you for clarification. I believe that while libva is not in OpenBSD, it presents in FreeBSD and they are dealing with basically the same issue. Here is their patch: https://svnweb.freebsd.org/ports/head/multimedia/libva/files/patch-va_va__trace.c?view=markup. Moreover, looking into it they are doing pretty the same as you do in this PR and it seems they thought about OpenBSD support:
https://svnweb.freebsd.org/ports/head/multimedia/libva/files/patch-va_va__trace.c?view=markup#l36. Can you, please, evaluate whether this change will work for you?

Anyhow, I believe we need to take FreeBSD effort into account and simplify everyone's live providing support for variety of operating systems. As of now FreeBSD patch seems to be more generic. I suggest to put it under review here. Would you mind to create corresponding PR or update this one?

@iarebatman
Copy link
Author

@iarebatman : thank you for clarification. I believe that while libva is not in OpenBSD, it presents in FreeBSD and they are dealing with basically the same issue. Here is their patch: https://svnweb.freebsd.org/ports/head/multimedia/libva/files/patch-va_va__trace.c?view=markup. Moreover, looking into it they are doing pretty the same as you do in this PR and it seems they thought about OpenBSD support:
https://svnweb.freebsd.org/ports/head/multimedia/libva/files/patch-va_va__trace.c?view=markup#l36. Can you, please, evaluate whether this change will work for you?

Anyhow, I believe we need to take FreeBSD effort into account and simplify everyone's live providing support for variety of operating systems. As of now FreeBSD patch seems to be more generic. I suggest to put it under review here. Would you mind to create corresponding PR or update this one?

It does look like their patches would work. I will close this PR and create a new one.

@iarebatman iarebatman closed this Dec 10, 2019
@jbeich jbeich mentioned this pull request Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants